Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(generic-metrics): Add DLQ back to generic metrics storages #4964

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

ayirr7
Copy link
Member

@ayirr7 ayirr7 commented Nov 1, 2023

These were removed some time ago due to an investigation, I think they can be brought back now

@ayirr7 ayirr7 requested a review from a team as a code owner November 1, 2023 20:35
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edd65aa) 90.04% compared to head (c0fcc95) 90.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4964   +/-   ##
=======================================
  Coverage   90.04%   90.04%           
=======================================
  Files         892      892           
  Lines       43238    43238           
  Branches      288      288           
=======================================
  Hits        38932    38932           
  Misses       4264     4264           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ayirr7 ayirr7 merged commit 0c9eb3b into master Feb 8, 2024
32 checks passed
@ayirr7 ayirr7 deleted the add-dlq-gen-metrics branch February 8, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants