ref(ddm): Disable metrics in Snuba #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a bug in uwsgi + the python sdk that causes restarts and hangs when using metrics. Going to disable this for now until things stabilize.
enochtangg
approved these changes
Feb 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5497 +/- ##
==========================================
+ Coverage 90.10% 92.53% +2.43%
==========================================
Files 888 850 -38
Lines 43333 41767 -1566
Branches 288 0 -288
==========================================
- Hits 39044 38651 -393
+ Misses 4247 3116 -1131
+ Partials 42 0 -42 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in uwsgi + the python sdk that causes restarts and hangs when
using metrics. Going to disable this for now until things stabilize.