Downgrade and pin zip to fix SourceBundles with >64k files (#846)

The recent symbolicator update started emitting errors related to this. After a short debugging sessions, I pinned down the problem to a regression in `zip` which broke archives with >64k files.
getsentry · Jun 7, 2024 · 8812f94 · 8812f94
1 parent 9806d26
commit 8812f94
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+- Downgrade and pin `zip` to fix SourceBundles with >64k files ([#846](https://github.com/getsentry/symbolic/pull/846))
+
 ## 12.9.1
 
 **Features**

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -62,7 +62,8 @@ uuid = "1.3.0"
 walkdir = "2.3.1"
 wasmparser = "0.209.1"
 watto = { version = "0.1.0", features = ["writer", "strings"] }
-zip = { version = "2.1.2", default-features = false, features = ["deflate"] }
+# We are currently pinning a known good version prior to https://github.com/zip-rs/zip2/issues/189
+zip = { version = "=2.1.1", default-features = false, features = ["deflate"] }
 zstd = { version = "0.13.1" }