Downgrade and pin zip to fix SourceBundles with >64k files
#846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent symbolicator update started emitting errors related to this. After a short debugging sessions, I pinned down the problem to a regression in `zip` which broke archives with >64k files.
Swatinem
force-pushed
the
swatinem/downgrade-zip
branch
from
4ac7d7b
to
8f9714f
Compare
anonrig
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent symbolicator update started emitting errors related to this. After a short debugging sessions, I pinned down the problem to a regression in
zipwhich broke archives with >64k files.See zip-rs/zip2#189 which is also linked from the
Cargo.toml.