fix(build): use cli git to save some ram with cargo #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rust-lang/cargo#9167
cargo without this setting uses
libgit2which appears to have a pretty bad memory leak (consuming ~9GB of ram and then never freeing it) -- later leading to an out-of-memory (docker exits with code 247)on my x86_64 linux VM emulating arm64 via qemu this reduces the maximum memory usage of the build process from ~13GB to 2.7GB
test run here: https://github.com/getsentry/symbolic/runs/6530937203?check_suite_focus=true