Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Persist SourceMap name in the cache. #698

Merged
merged 7 commits into from
Oct 17, 2022
Merged

ref: Persist SourceMap name in the cache. #698

merged 7 commits into from
Oct 17, 2022

Conversation

Swatinem
Copy link
Member

Anonymous functions are most of the time being called through a variable binding, which when minified gets a name mapping. This information from the parent/caller frame can be used as a good heuristic as fallback for a scope name.

Anonymous functions are most of the time being called through a variable
binding, which when minified gets a `name` mapping. This information from
the parent/caller frame can be used as a good heuristic as fallback for a
scope name.
@Swatinem
Copy link
Member Author

This PR does not strictly depend on a new version of js-source-scopes, I can also change it to be able to land this directly.

@loewenheim
Copy link
Contributor

I think the code could use some explanation of what the name of a token/source location is.

@Swatinem Swatinem marked this pull request as ready for review October 17, 2022 10:45
@Swatinem Swatinem requested a review from a team October 17, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants