feat(smcache): Expose token name via Python bindings #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
force-pushed
the
sourcemapcache-token-name
branch
from
6a775d4
to
e10c3d5
Compare
Swatinem
approved these changes
Oct 31, 2022
| @@ -156,6 +158,7 @@ fn make_token_match(token: SourceLocation, context_lines: u32) -> *mut SymbolicS | |||
| line: token.line() + 1, | |||
| col: token.column() + 1, | |||
| src: SymbolicStr::new(token.file_name().unwrap_or_default()), | |||
| name: SymbolicStr::new(token.name().unwrap_or_default()), | |||
There was a problem hiding this comment.
The unwrap_or_default means we will return an empty string in case there is no name. is that really what we want?
There was a problem hiding this comment.
Yes, because decode_str will then return '', which then will fallback to None in sourcemapcache.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #698