Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strip query strings and fragments from sourcemap URLs #809

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

loewenheim
Copy link
Contributor

No description provided.

@loewenheim loewenheim self-assigned this Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #809 (680b862) into master (11472bf) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 84.00%.

❗ Current head 680b862 differs from pull request most recent head ede8c1e. Consider uploading reports for the commit ede8c1e to get more accurate results

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
- Coverage   74.88%   74.87%   -0.01%     
==========================================
  Files          63       63              
  Lines       15649    15663      +14     
==========================================
+ Hits        11718    11728      +10     
- Misses       3931     3935       +4     

@loewenheim loewenheim enabled auto-merge (squash) September 6, 2023 08:50
@loewenheim loewenheim merged commit 1bd4162 into master Sep 6, 2023
11 checks passed
@loewenheim loewenheim deleted the fix/sourcemap-urls branch September 6, 2023 08:54
loewenheim added a commit to getsentry/symbolicator that referenced this pull request Sep 7, 2023
This pulls in getsentry/symbolic#809, which means that source mapping URLs will be read without query strings or fragments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants