fix: Handle queries and fragments in sourcemap URLs #1734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a query parameter and a fragment to some injection test fixtures. |
Swatinem
reviewed
Sep 5, 2023
| @@ -327,7 +327,15 @@ impl SourceMapProcessor { | |||
| }; | |||
|
|
|||
| let sourcemap_url = match discover_sourcemaps_location(contents) { | |||
There was a problem hiding this comment.
should we move this to this function?
I’m a bit unsure, as in symbolicator when we scrape the sourceMappingURL from the file because we had no bundle "header" to take it from, we have to strip these when looking up the sourcemap in the bundles we have, but having these present in case we fall back to scraping might actually be beneficial.
When in doubt, I would rather just strip them reliably as early as possible.
|
We'll fix this on the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manually strips away query strings and fragments from source mapping URLs, making sure that the sourcemap file is correctly associated with the source file.