Skip to content

Commit

Permalink
doc(sources): Document rationale for Sentry list_file behavior (#1372)
Browse files Browse the repository at this point in the history
  • Loading branch information
loewenheim committed Feb 15, 2024
1 parent e145e5c commit dc0eb62
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions crates/symbolicator-service/src/download/sentry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,10 @@ impl SentryDownloader {
.append_pair("code_id", code_id.as_str());
}

// NOTE: We intentionally don't limit the query to the provided file types, even though
// the endpoint supports it. The reason is that the result of the query gets cached locally
// and we can then filter the cached results. This saves us from making individual requests to Sentry
// for every file type or combination of file types we need.
let query = SearchQuery {
index_url,
token: source.token.clone(),
Expand Down

0 comments on commit dc0eb62

Please sign in to comment.