Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(sources): Document rationale for Sentry list_file behavior #1372

Merged
merged 3 commits into from Feb 15, 2024

Conversation

loewenheim
Copy link
Contributor

The debug files endpoint in Sentry supports querying by a list of file formats:
https://github.com/getsentry/sentry/blob/e23668f702957cc09d47977cacfa2b9c8b384928/src/sentry/api/endpoints/debug_files.py#L248

https://github.com/getsentry/sentry/blob/e23668f702957cc09d47977cacfa2b9c8b384928/src/sentry/api/endpoints/debug_files.py#L281-L287

Therefore we can already do the filtering by file type when we make the query to the Sentry source, instead of getting all files and filtering afterwards.

@loewenheim loewenheim requested a review from a team February 15, 2024 13:05
@loewenheim loewenheim self-assigned this Feb 15, 2024
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was done intentionally to improve cache efficiency of the lookup cache, as well as reduce the outgoing requests to Sentry.

I believe I even wrote a shipped email about it because it turned out to be a very visible improvement.

@loewenheim loewenheim changed the title ref(sources): Add file type query to Sentry sources doc(sources): Document rationale for Sentry list_file behavior Feb 15, 2024
@loewenheim
Copy link
Contributor Author

I've changed the PR to instead add a note about why it works the way it does.

@loewenheim loewenheim enabled auto-merge (squash) February 15, 2024 15:46
@loewenheim loewenheim merged commit dc0eb62 into master Feb 15, 2024
10 checks passed
@loewenheim loewenheim deleted the ref/sentry-filetypes branch February 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants