ref: Use moka for Cacher implementation, 2nd try
#1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
- Coverage 74.14% 74.12% -0.03%
==========================================
Files 81 81
Lines 11399 11384 -15
==========================================
- Hits 8452 8438 -14
+ Misses 2947 2946 -1 |
Swatinem
added a commit
that referenced
this pull request
Feb 2, 2023
We can extract this from #1010, and this should help with moka-rs/moka#212 even if we do not (yet) switch to more widespread moka usage.
Replaces the current request coalescing solution with `moka`. This simplifies the channel creation and deduplication logic, as `moka` does that already. This also gives us in-memory caches right now, even though they are not hooked up to configuration yet.
|
Seems to be stable so far, lets try to roll this out tomorrow. |
loewenheim
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #979:
Replaces the current request coalescing solution with
moka. This simplifies the channel creation and deduplication logic, asmokadoes that already. This also gives us in-memory caches right now, even though they are not hooked up to configuration yet.Just opening this for now that its not lost