ref: Use moka for Cacher implementation
#979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
reviewed
Jan 16, 2023
Swatinem
force-pushed
the
ref/moka-cache
branch
from
fb65172
to
98c80a0
Compare
loewenheim
force-pushed
the
ref/moka-cache
branch
from
448a2ee
to
98c80a0
Compare
Swatinem
force-pushed
the
ref/moka-cache
branch
2 times, most recently
from
3aff52e
to
f79f167
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #979 +/- ##
==========================================
+ Coverage 74.12% 74.26% +0.13%
==========================================
Files 75 75
Lines 11439 11504 +65
==========================================
+ Hits 8479 8543 +64
- Misses 2960 2961 +1 |
Closed
Replaces the current request coalescing solution with `moka`. This simplifies the channel creation and deduplication logic, as `moka` does that already. This also gives us in-memory caches right now, even though they are not hooked up to configuration yet.
Swatinem
force-pushed
the
ref/moka-cache
branch
from
2028ca2
to
f9b18b4
Compare
loewenheim
approved these changes
Jan 27, 2023
Swatinem
commented
Jan 27, 2023
| // - ^ Well actually, eager `computations` should be `file.hits + file.miss - file.fallback`, | ||
| // as cache fallback does trigger a background computation. | ||
| // - in-memory miss: access - computations | ||
| // FIXME: is it better to use a different metrics key or tags for the cache name? |
There was a problem hiding this comment.
NOTE: for datadog it does not matter if we use different keys or tags. I would even prefer to have tags instead, but that might be a good followup.
There was a problem hiding this comment.
I would agree that tags seem like the natural choice.
Swatinem
added a commit
that referenced
this pull request
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the current request coalescing solution with
moka.This simplifies the channel creation and deduplication logic, as
mokadoes that already. This also gives us in-memory caches right now, even
though they are not hooked up to configuration yet.