Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(sources): Document rationale for Sentry list_file behavior #1372

Merged
merged 3 commits into from
Feb 15, 2024
Merged

doc(sources): Document rationale for Sentry list_file behavior #1372

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14ca9bf
ref(sources): Add file type query to Sentry sources
loewenheim Feb 15, 2024
314da8b
Document current behavior
loewenheim Feb 15, 2024
e13235b
Typo
loewenheim Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions crates/symbolicator-service/src/download/sentry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ impl SentryDownloader {
.append_pair("code_id", code_id.as_str());
}

// NOTE: We intentionally don't limit the query to the provided file types, even though
// the endpoint supports it. The reason is that the result of the query gets cached locally
// and we can then filter the cached results. This saves us from making individual requests to Sentry
// for ever file type or combination of file types we need.
let query = SearchQuery {
index_url,
token: source.token.clone(),
Expand Down