feat(metrics): Add option to send environment with every metric #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Aug 6, 2021
relaxolotl
reviewed
Aug 6, 2021
crates/symbolicator/src/metrics.rs
Outdated
Comment on lines
9
to
13
| // Type aliases to make the definition of [`MetricsClient`] more readable. | ||
| type Hostname = String; | ||
| type HostnameTag = String; | ||
| type Environment = String; | ||
| type EnvironmentTag = String; |
There was a problem hiding this comment.
apologies if this ends up sounding being pretty pedantic.
from a readability standpoint, i get why this exists but i'm a little torn about it, because i'm left wondering a few things as a result of this:
- can any string be one of these four types? are there any restrictions on the contents of these strings at all?
- should you be able to use a
Hostnameas anEnvironmentorHostnameTagorEnvironmentTag? you're not using a newtype here, but one of the nice perks of wrapping strings in newtypes is that it's hard to mix up different strings that represent or mean different things, ie you can't accidentally use anEnvironmentas aHostname.
i'm hesitant about the way we're softly baking these into the type system if it doesn't take advantage of the checking that the system provides.
There was a problem hiding this comment.
I've replaced the two dedicated tag/value pairs on MetricsClient with a BTreeMap. I believe that makes the everything both clearer and more robust.
relaxolotl
approved these changes
Aug 17, 2021
Swatinem
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #513.
Symbolicator obtains the environment from its Sentry client, which in turn determines it based on the
SENTRY_ENVIRONMENTvariable or the build config if that's not set.This addresses https://getsentry.atlassian.net/browse/NATIVE-165.