Attempt to fix build order bug #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uncovered while building with samurai [0] but can probably also
happen with ninja eventually.
In file included from ../src/mate-applet/applet.c:19:
In file included from ../src/frontend/classic/classic-window.h:14:
../src/frontend/classic/../menu-private.h:18:10: fatal error: 'libsaver-glue.h' file not found
#include "libsaver-glue.h"
^~~~~~~~~~~~~~~~~
1 error generated.
samu: subcommands failed
[0] https://github.com/michaelforney/samurai
ghost
mentioned this pull request
|
Thanks for contributing! Tested in Debian SId, Ubuntu 20.04, 21.04, 21.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncovered while building with samurai [0] but can probably also
happen with ninja eventually.
In file included from ../src/mate-applet/applet.c:19:
In file included from ../src/frontend/classic/classic-window.h:14:
../src/frontend/classic/../menu-private.h:18:10: fatal error: 'libsaver-glue.h' file not found
#include "libsaver-glue.h"
^~~~~~~~~~~~~~~~~
1 error generated.
samu: subcommands failed
I'm not sure if this is right at all, but it fixed the build for me.
[0] https://github.com/michaelforney/samurai