Align partitions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks for the patch! We'll see that this gets further testing as we prep for release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to properly align partitions when creating them. The current incarnation makes no such attempt and gives misaligned partitions. This does cause worse performance, and can cause shortened disk life.
I am not an expert in this distro, nor have I read all of the code. It's been tested (by me) for a new installation with and without LUKS. I do not know if other schemes exist, such as creating partitions alongside existing ones, if so, that should likely be tested.
It's completely fine to not accept this PR as is and tune it yourself. Just offering what worked for me.
I copied these files from the live installer to work with rather than this repo(which explains the copyright commit), so please watchout for other changes that may have existed.