Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amule: Inclusion of homepage #429

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

FAb7D
Copy link
Contributor

@FAb7D FAb7D commented Oct 2, 2023

Summary

Test Plan

  • Launched the application

Checklist

  • Package was built and tested against unstable

@FAb7D FAb7D changed the title foo: Bump to relase 24 -inclusion of homepage amule: Bump to relase 24 -inclusion of homepage Oct 2, 2023
@FAb7D FAb7D changed the title amule: Bump to relase 24 -inclusion of homepage amule: Bump to relase 24: inclusion of homepage Oct 2, 2023
@davidjharder
Copy link
Member

Good work getting everything set up. A few things:

  • Please change the title to amule: Inclusion of homepage
    • You don't need to mention the bump because you always have to bump
  • Please edit the description to use the header surrounded in asterisks **like this** and remove the duplicate headers starting with the hashes # like this
  • Don't say fixes #411, that will close the issue, and we have lots more homepages to fix first! Instead say part of #411
  • You can also check the box about building and testing against unstable
  • When you are done, your description should look something like this:
**Summary**

- The inclusion of "homepage" to package.yml
- Part of https://github.com/getsolus/packages/issues/411

**Test Plan**

- Launched the application

**Checklist**

- [x] Package was built and tested against unstable

@FAb7D FAb7D changed the title amule: Bump to relase 24: inclusion of homepage amule: Inclusion of homepage Oct 2, 2023
@FAb7D FAb7D force-pushed the bumping_amule branch 2 times, most recently from b43b42c to ec02994 Compare October 2, 2023 17:26
@FAb7D FAb7D marked this pull request as draft October 2, 2023 19:30
@FAb7D FAb7D marked this pull request as ready for review October 2, 2023 21:22
Copy link
Contributor

@TraceyC77 TraceyC77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for addressing all the previous review points.

@TraceyC77 TraceyC77 merged commit 6c24703 into getsolus:main Oct 3, 2023
@FAb7D FAb7D deleted the bumping_amule branch October 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants