Add optional linker flag icf={safe,all} to optimizations #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identical code folding folds identical functions into a single copy, saving disk space. Generally useful for large C++ applications. Only the gold linker can handle icf when using the gcc toolchain, although icf is generally superior when using llvm/lld. Additionally, fix a thinko where runpath wasn't being filtered from cflags/cxxflags.
Recommended in combination with ICF when using GCC toolchain, otherwise not recommended. However, there may be a use for it so leave it as a seperate option.
JoshStrobl
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical code folding folds identical functions into a single copy, saving disk space.
Generally useful for large C++ applications.
Only the gold linker can handle icf when using the gcc toolchain, although icf is generally superior when using llvm/lld.
Also add support for function-sections, this is recommended for use with ICF when using gcc/gold but not strictly necessary.
icf-all is not recommended for gcc/gold but is left as an option. icf-all is generally safe for clang/lld due to -faddrsig being default in clang.
Additionally, fix a thinko where runpath wasn't being filtered from cflags/cxxflags.