Improve Make targets and address various issues #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiddeco
force-pushed
the
imprv-make-targets
branch
2 times, most recently
from
ea08e83
to
6c31fab
Compare
hiddeco
force-pushed
the
imprv-make-targets
branch
8 times, most recently
from
06c49b7
to
0258725
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
``` stores/dotenv/store.go:74:12: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields stores/dotenv/store_test.go:29:10: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields keyservice/server.go:149:9: assignment copies lock value to key: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:206:20: call of ks.prompt copies lock value: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:214:22: keyToString passes lock by value: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:231:29: prompt passes lock by value: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:232:27: call of keyToString copies lock value: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:251:9: assignment copies lock value to key: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex keyservice/server.go:308:20: call of ks.prompt copies lock value: github.com/getsops/sops/v3/keyservice.Key contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex stores/yaml/store_test.go:27:11: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields stores/yaml/store_test.go:39:11: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields stores/yaml/store_test.go:107:5: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields stores/yaml/store_test.go:139:13: github.com/getsops/sops/v3.Comment struct literal uses unkeyed fields decrypt/example_test.go:34:1: ExampleDecryptFile refers to unknown identifier: DecryptFile ``` Signed-off-by: Hidde Beydals <hidde@hhh.computer>
As it has been deprecated for about ~2 years in favor of `go vet` and tools like `staticcheck`. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
Deprecation of `io/ioutil`, removal of unused functions, possible nil pointer dereference, and other tiny nits. There are (many) more, but these would require their own (commit) context. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
My assumption is that this used to be in place because of `go` not ignoring the `vendor` directory. However, in 2023 this appears to no longer be an issue, and only adds complexity. While running `go test ./...` works just fine. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
This should just really not be put there, but lets be nice and ignore it for now. Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
imprv-make-targets
branch
from
0258725
to
aa7922f
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
imprv-make-targets
branch
from
aa7922f
to
218c412
Compare
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
imprv-make-targets
branch
from
218c412
to
fe346f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the
Makefilea bit more, while still not being picture perfect. Things that could still use some love:./functional-tests/sops. But instead put in./bin/sops, from where it would be used instead (while building using GoReleaser to match release build?)