Fixed exception when converting an HTML table to native kramdown elem…

…ents This fixes #101 which didn't provide a general solution.
gettalong · Jun 4, 2014 · 4705ca7 · 4705ca7
1 parent bb26b60
commit 4705ca7
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 1 deletion.
diff --git a/lib/kramdown/parser/html.rb b/lib/kramdown/parser/html.rb
@@ -420,7 +420,7 @@ def convert_table(el)
                 if td.attr['style']
                   td.attr['style'].slice!(/(?:;\s*)?text-align:\s+(center|left|right)/)
                   td.attr.delete('style') if td.attr['style'].strip.empty?
-                  $1.to_sym
+                  $1 ? $1.to_sym : :default
                 else
                   :default
                 end

diff --git a/test/test_files.rb b/test/test_files.rb
@@ -116,6 +116,7 @@ def tidy_output(out)
                           'test/testcases/block/12_extension/options3.text', # bc of options option
                           'test/testcases/block/09_html/content_model/tables.text',  # bc of parse_block_html option
                           'test/testcases/block/09_html/html_to_native/header.text', # bc of auto_ids option that interferes
+                          'test/testcases/block/09_html/html_to_native/table_simple.text', # bc of tr style attr getting removed
                           'test/testcases/block/09_html/simple.text',        # bc of webgen:block elements
                           'test/testcases/block/11_ial/simple.text',         # bc of change of ordering of attributes in header
                           'test/testcases/span/extension/comment.text',      # bc of comment text modifications (can this be avoided?)

diff --git a/test/testcases/block/09_html/html_to_native/table_simple.html b/test/testcases/block/09_html/html_to_native/table_simple.html
@@ -32,6 +32,19 @@
   </tfoot>
 </table>
 
+<table class="examples">
+  <tbody>
+    <tr>
+      <td style="text-align: left">Usage</td>
+      <td style="width: 10em">Output</td>
+    </tr>
+    <tr>
+      <td style="text-align: left">Some *data*</td>
+      <td>Some more</td>
+    </tr>
+  </tbody>
+</table>
+
 <table class="examples">
 <tr>
   <th>Usage</th>

diff --git a/test/testcases/block/09_html/html_to_native/table_simple.text b/test/testcases/block/09_html/html_to_native/table_simple.text
@@ -40,6 +40,21 @@ locker
 </tfoot>
 </table>
 
+<table class="examples">
+<tr>
+  <td style="text-align: left">Usage</td>
+  <td style="width: 10em">
+Output
+  </td>
+</tr>
+<tr>
+  <td style="text-align: left">Some *data*</td>
+  <td>
+Some more
+  </td>
+</tr>
+</table>
+
 <table class="examples">
 <tr>
   <th>Usage</th>