Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore. #542

Closed
wants to merge 1 commit into from
Closed

Conversation

junaruga
Copy link
Contributor

  • Add "/" to ignore the top directories.
  • Add ignored nvm install directory and katex directory that are created after installing the dependency packages.

For example, currently when creating below file test/pkg/a.txt, the file is ignored unintentionally.

$ mkdir test/pkg/
$ touch test/pkg/a.txt

But after this pull-request, it is appeared.

$ git status
On branch hotfix/gitignore
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	test/pkg/

* Add "/" to ignore the top directories.
* Add ignored node_modules and katex directory.
@gettalong
Copy link
Owner

I see what you get at but this is currently no problem and I don't think that it will be in the near future.

@gettalong gettalong closed this Aug 28, 2018
@junaruga
Copy link
Contributor Author

I see. How about the directories I added?

node_modules
katex

When you do tests on you local, you see the untracked files by git status don't you?

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

	katex/
	node_modules/

@junaruga
Copy link
Contributor Author

Ah an another person talked with you about the same topic in another PR.
#518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants