Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the limited set of tag icons by emojis #85

Closed
tkdchen opened this issue Jan 2, 2015 · 6 comments · Fixed by #508
Closed

Replace the limited set of tag icons by emojis #85

tkdchen opened this issue Jan 2, 2015 · 6 comments · Fixed by #508
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low
Milestone
0.5 "You Can (Not...

Comments

@tkdchen
Copy link
Contributor

tkdchen commented Jan 2, 2015

It would be a nice feature to allow to specify a custom icon for a tag.
@vrutkovs
Copy link

This is already supported in 0.3.x - see 'Click to set icon' button
tag editor

@tkdchen
Copy link
Contributor Author

tkdchen commented Jan 13, 2015

@vrutkovs cannot select other icons from file system except the fixed set of icon listed by "Click To Set Icon"

@vrutkovs
Copy link

@tkdchen ah, yes, that would be a nice feature. At least updating a current list of available icons would be nice

@izidormatusov izidormatusov added priority:low low-hanging-fruit "Easy picks" suitable for new contributors to tackle labels Mar 15, 2015
@izidormatusov izidormatusov added this to the 0.4 milestone Mar 15, 2015
@izidormatusov izidormatusov removed this from the 0.4 milestone Jun 18, 2015
@izidormatusov
Copy link
Contributor

This is outside of the scope of 0.4 milestone that we would release after summer.

@nekohayo
Copy link
Member

I would like to see the oldschool icons support replaced by GTK3's emojis support. It would be much nicer-looking, more portable, and reduce the amount of stuff we need to ship with the app. Patches welcome!

@nekohayo nekohayo changed the title Allow to specify a custom icon for a tag Replace the limited set of tag icons by emojis Dec 11, 2019
@nekohayo nekohayo added this to the 0.5 "Die Hard" milestone Dec 11, 2019
@diegogangl diegogangl mentioned this issue May 10, 2020
Closed
@diegogangl diegogangl mentioned this issue Jun 22, 2020
Closed
@Neui Neui mentioned this issue Oct 3, 2020
Merged
diegogangl added a commit that referenced this issue Nov 5, 2020
@diegogangl
Replace custom icons selector with emoji picker
86ae2c0 
"Custom icons" was kind of a misnomer, since you could only select from
a short list of icons. These icons probably changed over time since they
were introduced, and at the time of this commit had come to have
different styles and sizes. Most of them were useless as icons or
duplicates.

This commit starts replacing them with emojis, which are basically a
+3,000 icon set baked into the toolkit.

ref #85
diegogangl added a commit that referenced this issue Nov 5, 2020
@diegogangl
Use emoji in cell renders
50e8d80 
closes #85
diegogangl added a commit that referenced this issue Nov 6, 2020
@diegogangl
Show placeholder icon for emoji selector
9ff2f32 
ref #85
diegogangl added a commit that referenced this issue Nov 6, 2020
@diegogangl
Add button remove icons
2136840 
ref #85
@diegogangl diegogangl mentioned this issue Nov 6, 2020
Merged
@nekohayo nekohayo mentioned this issue Dec 10, 2020
Closed
@Neui Neui mentioned this issue Dec 12, 2020
Closed
diegogangl added a commit that referenced this issue Jan 17, 2021
@diegogangl
Replace custom icons selector with emoji picker
935f6ce 
"Custom icons" was kind of a misnomer, since you could only select from
a short list of icons. These icons probably changed over time since they
were introduced, and at the time of this commit had come to have
different styles and sizes. Most of them were useless as icons or
duplicates.

This commit starts replacing them with emojis, which are basically a
+3,000 icon set baked into the toolkit.

ref #85
diegogangl added a commit that referenced this issue Jan 17, 2021
@diegogangl
Use emoji in cell renders
1897f24 
closes #85
diegogangl added a commit that referenced this issue Jan 17, 2021
@diegogangl
Show placeholder icon for emoji selector
f1fad95 
ref #85
diegogangl added a commit that referenced this issue Jan 17, 2021
@diegogangl
Add button remove icons
18cfd50 
ref #85
@nekohayo
Copy link
Member

A tiny nitpick for @diegogangl in commit 18cfd50:

  • The 10% opaque default label icon is very hard to see in a light theme?
  • The "Remove icon" button label is not marked as translatable, I think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low-hanging-fruit "Easy picks" suitable for new contributors to tackle priority:low
Projects
None yet
Milestone
0.5 "You Can (Not) Improve Performance"
Development

Successfully merging a pull request may close this issue.

Replace icons with emojis getting-things-gnome/gtg
5 participants
@izidormatusov @vrutkovs @diegogangl @nekohayo @tkdchen