Revert meson plugin translation apply thing #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since meson 0.60, the `build_always_stale` option was removed: mesonbuild/meson@6b1a800 However, meson doesn't make such files depend on the translation .po files, which is a known bug: mesonbuild/meson#2621 So with that option taken away, I tried passing a list to the input which includes all .po files, since I saw it only uses the first element for the translations, but that fails when trying to generate po files. Since it seems you can't dynamically add dependencies after the fact, this seems like a dead end, so I am reverting this for now to make it compile on meson 0.60.
|
Could we run |
You mean in the |
|
Merged, we can take a look at the script afterwards. Thanks! |
ncfavier
added a commit
to ncfavier/nixpkgs
that referenced
this pull request
Jan 22, 2022
Adds upstream patch from getting-things-gnome/gtg#729 to fix the error about unknown keyword arguments
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since meson 0.60, the
build_always_staleoption was removed:mesonbuild/meson@6b1a800
However, meson doesn't make such files depend on the translation .po
files, which is a known bug:
mesonbuild/meson#2621
So with that option taken away, I tried passing a list to the input
which includes all .po files, since I saw it only uses the first element
for the translations, but that fails when trying to generate po files.
Since it seems you can't dynamically add dependencies after the fact,
this seems like a dead end, so I am reverting this for now to make it
compile on meson 0.60.
Reverts #555 to fix #720