Reduce decoy backup frequency #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lukechilds
added a commit
that referenced
this pull request
Sep 2, 2020
Ahmed262111
pushed a commit
to Ahmed262111/umbrel
that referenced
this pull request
May 27, 2024
Agree with @pointbiz that the blast of blockstats requests made on startup (to calculate 24hr volume) should be blocked on "slow devices".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had originally incorrectly assumed the LND channel.backup changes with each channel state change so we needed lots of decoys to reduce channel state change information leakage.
However the file only changes on channel open/close so we can safely reduce the decoy backup frequency.