Handle upload fail #215
Merged
Handle upload fail #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Makes me wonder if we should add a while loop and retry uploading the backup for like 5 or 10 times before exiting the script? |
|
If we're going to retry we should probably do that in a a wrapper around the entire backup logic to avoid a race condition. It opens the possibility of getting in a retry loop due to a network failure, a separate backup gets triggered, networking now works again, the new backup uploads, then our retry works and we overwrite the latest backup with an outdated backup. So we should rebuild the backup file from the latest files on disk. Maybe we can merge this as is and look into that as a separate PR. |
mayankchhabra
approved these changes
Sep 2, 2020
Merged
lukechilds
added a commit
that referenced
this pull request
Sep 2, 2020
Ahmed262111
pushed a commit
to Ahmed262111/umbrel
that referenced
this pull request
May 27, 2024
- special case to show textarea for "message" arg on "verifymessage" method - strip carriage returns before sending to node - after obtaining result, fix for rendering newlines back into textarea (since the newlines got mashed via JSON.stringify before being sent via RPC interface) - minor frontend style tweaks on /rpc-browser - minor logging tweaks for /rpc-browser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the upload fails the backup script exits uncleanly.
This PR correctly handles a failed upload by allowing the script to clean up and prints the error in the logs.