Migrate poetry #49
Merged
Migrate poetry #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctbur
reviewed
Jul 30, 2021
| @@ -4,13 +4,16 @@ | |||
| from typing import List, Optional | |||
|
|
|||
| import click | |||
| from single_source import get_version | |||
There was a problem hiding this comment.
https://pypi.org/project/single-source/
Such a specific functionality but still so generally useful.
ctbur
reviewed
Jul 30, 2021
Comment on lines
+22
to
+26
| marshmallow = "*" | ||
| marshmallow-dataclass = "*" | ||
| click = "*" | ||
| pygithub = "*" | ||
| pyyaml = "*" |
There was a problem hiding this comment.
Thought about this again. We should probably set specific versions here as the package generated with poetry build does not take the lockfile into account, it only declares the direct dependencies as specified here.
Edit: Looks like we had it unpinned before. IIRC it was because of incompatibilities between Python versions.
ctbur
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from pipenv to poetry