fix/AzureOpenAI embeddings and LLM deployment name (dc) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves "The API deployment for this resource does not exist" for LLM and embedding models deployed in Azure OpenAI by deployment name supported in tmc/langchaingo#253 We can't Validate OpenAI LLM model names from hard-coded list in Azure because the model name parameter in API request is a deployment name, and while Microsoft advises us to use the model name as deployment name, we did not listen, and I didn't want to coordinate redeploying with a different name on a Friday. This also permits use of customized models that can be deployed in Azure side-by-side base models as added benefit so I think it was worthwhile.
danielchalef
temporarily deployed
to
build-test
GitHub Actions
Inactive
|
@ClaudiaJ Merged! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebase of @ClaudiaJ 's PR #171
will merge as #172 to ensure tests run correctly.
solves "The API deployment for this resource does not exist" for LLM and
embedding models deployed in Azure OpenAI by deployment name supported
in tmc/langchaingo#253
We can't Validate OpenAI LLM model names from hard-coded list in Azure
because the model name parameter in API request is a deployment name,
and while Microsoft advises us to use the model name as deployment name,
we did not listen, and I didn't want to coordinate redeploying with a
different name on a Friday.
This also permits use of customized models that can be deployed in Azure
side-by-side base models as added benefit so I think it was worthwhile.