Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/AzureOpenAI embeddings and LLM deployment name (dc) #172

Merged
merged 1 commit into from
Aug 28, 2023
Merged

fix/AzureOpenAI embeddings and LLM deployment name (dc) #172

merged 1 commit into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. fix/AuzreOpenAI embeddings and LLM deployment name 

    solves "The API deployment for this resource does not exist" for LLM and
embedding models deployed in Azure OpenAI by deployment name supported
in tmc/langchaingo#253

We can't Validate OpenAI LLM model names from hard-coded list in Azure
because the model name parameter in API request is a deployment name,
and while Microsoft advises us to use the model name as deployment name,
we did not listen, and I didn't want to coordinate redeploying with a
different name on a Friday.

This also permits use of customized models that can be deployed in Azure
side-by-side base models as added benefit so I think it was worthwhile.
    @ClaudiaJ @danielchalef
    ClaudiaJ authored and danielchalef committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fed860b View commit details
    Browse the repository at this point in the history