Handle failures during setup.sh
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, setup.sh did three things: * Create directory structure for the task * Export environment variables for the task * Perform any localization tasks (i.e., gsutil cp/cat) for the task We need to be able to catch errors arising from the third (localization) step. However, the first two steps need to be sourced in entrypoint.sh, since they export variables that must be available to script.sh when it's subsequently invoked in entrypoint.sh. Sourcing all three steps makes it difficult to recover any error codes from the localization step. Thus, we now source the first two steps in entrypoint.sh (via setup.sh), and break the localization tasks out into their own script (localization.sh), which entrypoint.sh runs. By recovering the exit code of localization.sh, we can infer whether the localization tasks failed Our previous approach of wrapping everything in setup.sh with set -e/set +e was problematic because it prevents teardown.sh from ever running -- since set -e get *sourced*, any errors during localization halt entrypoint.sh immediately.
julianhess
changed the title
set -e/unset -esetup.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires splitting it into two:
setup.shandlocalization.sh. Previously,setup.shdid three things:gsutil cp|cat) for the taskWe need to be able to catch errors arising from the third (localization) step.
However, the first two steps need to be sourced in
entrypoint.sh, since theyexport variables that must be available to
script.shwhen it's subsequentlyinvoked in
entrypoint.sh. Sourcing all three steps makes it difficult to recoverany error codes from the localization step.
Thus, we now source the first two steps in
entrypoint.sh(viasetup.sh),and break the localization tasks out into their own script (
localization.sh),which
entrypoint.shruns. By recovering the exit code oflocalization.sh, wecan infer whether the localization tasks failed
The first couple commits in this PR represent a flawed approach: wrapping everything in
setup.shwithset -e/set +ewas problematic because it prevents
teardown.shfrom ever running — sinceset -eget sourced, any errors during localization halt
entrypoint.shimmediately.