Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings about unknown languages even when code highlighting is disabled #2280

Closed
mrtnvgr opened this issue Aug 20, 2023 · 1 comment
Closed

Warnings about unknown languages even when code highlighting is disabled #2280

mrtnvgr opened this issue Aug 20, 2023 · 1 comment
Labels
bug good first issue

Comments

@mrtnvgr
Copy link

mrtnvgr commented Aug 20, 2023

Bug Report

Zola produces warnings about unknown highlight languages even when markdown.highlight_code = false.

Environment

Zola version: 0.17.2

Expected Behavior

Zola should not validate highlight languages when code highlighting is turned off.

Current Behavior

Logs:

Building site...
Warning: Highlight language shell-session not found in blog/x.md
Warning: Highlight language shell-session not found in blog/x.md
Warning: Highlight language shell-session not found in blog/x.md
Warning: Highlight language shell-session not found in blog/x.md
Warning: Highlight language shell-session not found in blog/x.md

Step to reproduce

config.toml

...
[markdown]
highlight_code = false
...
@mrtnvgr mrtnvgr changed the title Warnings about unknown highlight languages even when highlight_code is false Warnings about unknown languages even when code highlighting is disabled Aug 20, 2023
@welpo welpo mentioned this issue Aug 30, 2023
Merged
2 tasks
Keats pushed a commit that referenced this issue Aug 30, 2023
@welpo
fix: suppress highlight language warnings if highlight_code is false (#…
674c433 
…2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: #2280
@mrtnvgr
Copy link
Author

mrtnvgr commented Aug 31, 2023

Thanks @welpo!

@mrtnvgr mrtnvgr closed this as completed Aug 31, 2023
peterprototypes pushed a commit to peterprototypes/zola that referenced this issue Sep 12, 2023
@welpo @peterprototypes
fix: suppress highlight language warnings if highlight_code is false (g…
73d2f7c 
…etzola#2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: getzola#2280
technimad pushed a commit to technimad/zola that referenced this issue Sep 30, 2023
@welpo
fix: suppress highlight language warnings if highlight_code is false (g…
e8a8c8a 
…etzola#2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: getzola#2280
Keats pushed a commit that referenced this issue Dec 18, 2023
@welpo @Keats
fix: suppress highlight language warnings if highlight_code is false (#…
670b882 
…2287)

The warning about unknown highlight languages was displayed even when
code highlighting was disabled via `markdown.highlight_code = false`.
This commit adds a condition to check this setting before issuing the
warning, effectively suppressing it when code highlighting is disabled.

Issue: #2280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Keats @mrtnvgr