Escape path for live reload. Fix #1247. #1266
Conversation
src/cmd/serve.rs
Outdated
| "originalPath": "", | ||
| "liveCSS": true, | ||
| "liveImg": true, | ||
| "protocol": ["http://livereload.com/protocols/official-7"] | ||
| }}"#, | ||
| reload_path |
There was a problem hiding this comment.
I think we can write that one by hand, I don't really understand why this fixes the problem tbh
There was a problem hiding this comment.
The problem isn't the path, the path's fine, the problem is that "D:\Some\Directory\path.html" is not valid JSON. Because \ like in Rust, is an escape sequence, so it fails to parse. It should become "D:\\Some\\Directory\\path.html". I chose serde_json because it's already in the dependency hierarchy anyways (the templates use it).
There was a problem hiding this comment.
I see! Can you rebase? The tests should pass after that
There was a problem hiding this comment.
Ah yeah, didn't see the commit that snuck in there. It's done now.
There was a problem hiding this comment.
There's still something messed up in there. I'll look into it I guess. I'll just hard reset and patch.
There was a problem hiding this comment.
Alright, should be all good now.
zola serve's live reload feature used to fail on Windows due to the path separator (`\`) to not being escaped.
|
Perfect thanks! |
Sanity check:
Code changes
nextbranch?This is a fix for #1247.