Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP 404 instead of empty response if not found #1580

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

vilcans
Copy link
Contributor

@vilcans vilcans commented Aug 6, 2021

Fixes #1578

Problem was that if tokio::fs::metadata (which gets data about the file) failed, zola didn't return a proper HTTP error code.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@Keats Keats merged commit 040b0de into getzola:next Aug 6, 2021
@Keats
Copy link
Collaborator

Keats commented Aug 6, 2021

Thanks!

Keats pushed a commit that referenced this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants