Improved is_colocated_asset_links
#1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR includes the following: - Added a check for `../` which would check to see if a file is in a _sub_ directory - Wrote test for `is_colocated_asset_links` This PR is similare to PR #1969
JoelMon
changed the title
is_colocated_asset_links
Keats
approved these changes
Aug 17, 2022
|
Still some rebase issues, I'll see what I can do |
Sorry about that. I thought I had resolved it. Not sure what's going wrong. I can try deleting my fork and doing the commits again from scratch. Let me know. |
Keats
pushed a commit
that referenced
this pull request
Feb 16, 2023
This PR includes the following: - Added a check for `../` which would check to see if a file is in a _sub_ directory - Wrote test for `is_colocated_asset_links` This PR is similare to PR #1969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following:
../which would check to see if a file is in asub directory
is_colocated_asset_linksThis PR is similar to PR #1969