lint

.pylintrc

@@ -3,7 +3,6 @@ load-plugins=pylint.extensions.bad_builtin,
    pylint.extensions.code_style,
    pylint.extensions.dict_init_mutate,
    pylint.extensions.dunder,
-   pylint.extensions.emptystring,
    pylint.extensions.comparison_placement,
    pylint.extensions.confusing_elif,
    pylint.extensions.for_any_all,
@@ -96,6 +95,7 @@ limit-inference-results=1
 
 # invalid-name, ; We get lots of these, especially in scripts. should fix many of them
 # protected-access, ; We have many cases of this; legit ones need to be examinid and commented, then this removed
+# no-self-use, ; common in superclasses with extension points
 # too-few-public-methods, ; Exception and marker classes get tagged with this
 # exec-used, ; should tag individual instances with this, there are some but not too many
 # global-statement,     ; should tag individual instances

src/gevent/_ffi/loop.py

@@ -223,7 +223,7 @@ def python_handle_error(self, handle, _revents):
                 watcher.stop()
             except: # pylint:disable=bare-except
                 watcher.loop.handle_error(watcher, *sys.exc_info())
-            return # pylint:disable=lost-exception
+            return # pylint:disable=lost-exception,return-in-finally
 
     def unhandled_onerror(self, t, v, tb):
         # This is supposed to be called for signals, etc.

src/gevent/_fileobjectcommon.py

@@ -658,6 +658,7 @@ def close(_fobj=fobj):
                     try:
                         _fobj.close()
                     except: # pylint:disable=bare-except
+                        # pylint:disable-next=return-in-finally
                         return sys.exc_info()
                     finally:
                         _fobj = None

src/gevent/tests/test__threading_native_before_monkey.py

@@ -33,6 +33,7 @@ def tearDownClass(cls):
     def test_main_thread(self):
         current = threading.current_thread()
         self.assertNotIsInstance(current, threading._DummyThread)
+        # pylint:disable-next=used-before-assignment
         self.assertIsInstance(current, monkey.get_original('threading', 'Thread'))
         # in 3.4, if the patch is incorrectly done, getting the repr
         # of the thread fails