Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch selectors module when select is patched on Python 3.4+ #591

Closed
jamadden opened this issue Jun 26, 2015 · 0 comments
Closed

Patch selectors module when select is patched on Python 3.4+ #591

jamadden opened this issue Jun 26, 2015 · 0 comments
Labels
PyVer: python3 Affects Python 3

Comments

@jamadden
Copy link
Member

Not doing so can leave things in a broken state because selectors will determine whether select.poll is available at import time. If it's imported before a patch is applied, then use of the selectors module will be broken, as will things like subprocess. See #446 (comment) for a rationale and that thread for an example of the kind of breakage we've seen before.
@jamadden jamadden added the PyVer: python3 Affects Python 3 label Jun 29, 2015
@codepainters codepainters mentioned this issue Jul 21, 2016
Merged
@jeffwidman jeffwidman mentioned this issue Feb 8, 2017
Open
hashbrowncipher pushed a commit to hashbrowncipher/gevent that referenced this issue Oct 20, 2018
@obestwalter
Tox -> tox (gevent#591)
e8891a5 
* gevent#589 change all incidences of "Tox" to "tox" in docs and output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PyVer: python3 Affects Python 3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamadden