Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set to dnf #1689

Closed
wants to merge 1 commit into from
Closed

Set to dnf #1689

wants to merge 1 commit into from

Conversation

fabaff
Copy link

@fabaff fabaff commented Oct 21, 2020

dnf is the default CLI tool for dealing with packages nowadays.

@jamadden
Copy link
Member

Do you know what version that changed it? It would be nice to note "use yum on XXX and after XXX use dnf".

@fabaff
Copy link
Author

fabaff commented Oct 21, 2020

dnf is the default since Fedora 22 (released in 2015) and also for CentOS 8/RHEL 8.

@@ -38,9 +38,9 @@ General Notes

apk add --virtual build-deps file make gcc musl-dev libffi-dev

On Fedora Rawhide for Fedora 33, one might need to do this::
On Fedora Rawhide or Fedora 33, one might need to do this::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On Fedora Rawhide or Fedora 33, one might need to do this::
On Fedora Rawhide for Fedora 33, one might need to do this::

I believe the "for" was correct there. This is documenting one specific system version, not all versions of Rawhide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I find the paragraph a bit confusing: Fedora is moving quickly but the referenced package names should be pretty stable. How about moving the referenced issues right below the Alpine instructions (these are all Alpine issues) and then write something like: "For Fedora (as of Fedora 33), one might need to do this::"?

I am aware that this is only somewhat related to the actual topic of this pull request, but I can submit a separate PR once I know that at least one person other than me would approve it.

@jamadden jamadden closed this in a62a4f4 Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants