Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set to dnf #1689

Closed
wants to merge 1 commit into from
Closed

Set to dnf #1689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/development/installing_from_source.rst
View file
Open in desktop
Expand Up @@ -38,9 +38,9 @@ General Notes

apk add --virtual build-deps file make gcc musl-dev libffi-dev

On Fedora Rawhide for Fedora 33, one might need to do this::
On Fedora Rawhide or Fedora 33, one might need to do this::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
On Fedora Rawhide or Fedora 33, one might need to do this::
On Fedora Rawhide for Fedora 33, one might need to do this::

I believe the "for" was correct there. This is documenting one specific system version, not all versions of Rawhide.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I find the paragraph a bit confusing: Fedora is moving quickly but the referenced package names should be pretty stable. How about moving the referenced issues right below the Alpine instructions (these are all Alpine issues) and then write something like: "For Fedora (as of Fedora 33), one might need to do this::"?

I am aware that this is only somewhat related to the actual topic of this pull request, but I can submit a separate PR once I know that at least one person other than me would approve it.


yum install python3-devel gcc kernel-devel kernel-headers make diffutils file
dnf install python3-devel gcc kernel-devel kernel-headers make diffutils file

See :issue:`1567`, :issue:`1559`, and :issue:`1566`.

Expand Down