Update sources from Firefox. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in above collections. (mozilla-mobile#20633)
The kotlin-allopen plugin could be getting applied for each variant we have in the app. With the changed code, it will only get applied once.
This was moved to once per day in https://bugzilla.mozilla.org/show_bug.cgi?id=1628413 when Google Play reviews were very slow. That hasn't been a problem for awhile, and the less frequent nightlies are causing delays getting new Android Components bumps shipped out.
* Filter out test target packages in Flank-x86 * Ignore verifyRunBlockingAndStrictModeSuppresionCount
…bile#20839) Co-authored-by: Ryan VanderMeulen <ryanvm@gmail.com>
…ttingsFragmentReducerTest
…tsSuggestionProviderTest
…lures in HomeFragmentTest The expectation is that replacing `return` with `answers` will compute the return value for the extension function again in order to avoid the error, "no answer found for: Settings".
…ProtectionExceptionsInteractorTest
…arViewTest This test seems to be hacking at the binding between Fenix and the BrowserToolbar to simulate toolbar events passing to the Fenix interactor. This is rather clumsy test that relies on the magic working of mockk instead of following a general unit testing strategy that would commonly require the class to be re-written to allow for better testing instead. It is far safer to remove this test since we are not guaranteeing anything in it and instead we see intermittent failures that make us lose more time. So therefore.. 🔥
…king protection panel
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
…to ETP details
…Settings from the Tracking Protection dialog
…ab and second-to-last tab, if the media tab was the last active tab. (mozilla-mobile#21141) * Issue mozilla-mobile#21140 - Updated recent tab logic to show media tab and second-to-last tab, if the media tab was the last active tab. * Fixed RecentTabsListFeatureTest unit test Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…resource test. This check doesn't seem high value because initializing a component only indicates a performance problem if it's slow, which is not most components, so it's likely to result in many false positives. To fix the intermittent, we won't lose much if we remove it.
We're not using the functionality so there's no sense in doing the work. However, we keep the wrapper: see the code comments for details.
…ssive resource test. This doesn't seem to be a high value test: increasing the view hierarchy depth will only result in a performance problem on low end devices if there is enough content on the new layer to cause the traversal to take longer. It's more likely to result in a hard-to-workaround false positive so we can remove it, like component init count.
* [WIP] New Layout for adding login and 'add login' button in 'SavedLoginsListView' to launch it. Fixed bindings. * [WIP] Removed "reveal password" button * [WIP] Added interactor for the add login screen * [WIP] Trying to check for duplicates * [WIP] Renaming "addNew..." with "add..." * [WIP] Check for duplicates * [WIP] Fixes after merge * Cleaning up the layout and making edit text for hostname selectable * Error handling on add login screen. Tests for interactors and controllers Co-authored-by: Vitaly V. Pinchuk <vetal.978@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…bile#21214) Co-authored-by: Ryan VanderMeulen <rvandermeulen@mozilla.com>
…l to the wrong tab when opened
pkirakosyan
added a commit
that referenced
this pull request
Sep 15, 2021
This reverts commit c4d2c1d.
pkirakosyan
added a commit
that referenced
this pull request
Sep 15, 2021
This reverts commit c4d2c1d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
To download an APK when reviewing a PR: