Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: creation flow story + wallet updates #906

Merged
merged 1 commit into from
May 26, 2023
Merged

fix: creation flow story + wallet updates #906

merged 1 commit into from
May 26, 2023

Conversation

jfrader
Copy link
Contributor

@jfrader jfrader commented May 25, 2023

Resolves GEY-2342

@jfrader jfrader requested a review from sajald77 May 25, 2023 21:11
@linear
Copy link

linear bot commented May 25, 2023

GEY-2342 Staging Issues for: Implement creation flow updates - page 0/4

  • the selection looks like it's clickable. It can be fixed simply by:

  1. remove the cursor becoming a clickable cursor. The cursor should remain the arrow, not image

  2. remove the green border effect for hover + click. since this makes it feel like it's clickable.

  3. remove the filling when you click. See larger icons here:

    Screen Shot 2023-05-22 at 15.56.06.png

    Typography - Geyser product designs (Figma)

    • Markdown: “Paste” button pastes to line below cursor
    • Missing the World or Global option for the project region
    • Shrink the Voltage logo
    • Suggestion: add a "Get a node" in the copy as clickable text (clicking on the logo might not be an intuitive CTA)

    Screenshot 2023-05-22 at 15.58.17.png

    • Don't show the error message if the lightning address field is empty

    Screenshot 2023-05-22 at 16.01.34.png

    • If the Lightning address field is left empty, the final screen still shows the "Launch Project". Clicking it shows an ApolloError "wrong format for the lightning address"

    Screenshot 2023-05-22 at 16.03.40.png

    • FUNCTIONAL: Saving as draft without entering the wallet details before leads to a "Not Found" screen"

    Screenshot 2023-05-22 at 16.09.26.png

    • FUNCTIONAL: going through the creation flow, adding ln address, click 'Launch project' leads me to the same "Oops! this page was not found" error.

@jfrader jfrader force-pushed the fran/gey-2342-staging-issues-for-implement-creation-flow-updates-page-04 branch from f0dd275 to a2962c5 Compare May 26, 2023 19:47
sajald77
sajald77 approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@sajald77 sajald77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Added some minor comments for improvements.

src/forms/components/MarkdownField.tsx Show resolved Hide resolved
src/pages/projectCreate/ProjectCreationWalletConnectionForm.tsx Show resolved Hide resolved
@jfrader jfrader merged commit 44973d6 into staging May 26, 2023
@jfrader jfrader deleted the fran/gey-2342-staging-issues-for-implement-creation-flow-updates-page-04 branch May 26, 2023 20:17
sajald77 added a commit that referenced this pull request May 30, 2023
@sajald77
Merge branch 'staging' into feat/dark-mode
754cd83 
* staging:
  fix: paragraphs padding in markdown + logo on landing color + ssr false (#915)
  feat: update draft modal copy (#913)
  fix: add spacing between project links (#912)
  feat: update project icon (#914)
  fix: geyser logo should be the same color as the let the sats (#909)
  feat: remove card canvas on mobile (#908)
  fix: update launch copy (#907)
  fix: creation flow story + wallet updates (#906)
  fix: topnavbar on story edit (#904)
  fix: add theme for remirror and update some copies (#905)
  Project landing page refactor (#903)
  feat: activate project on launch (#910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajald77 sajald77 sajald77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfrader @sajald77