-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
showel.js - result: util.inspect( result ) - why? #16
Comments
Dmitry this is under large discussion on issue #8, we are redoing a On Tue, Jan 24, 2012 at 10:22 AM, Dmitry Koterov
|
I suppose you should improve the serializer (and possibly deserializer at the caller side) around the whole { result: result, console: console } construction, not around the result only! I am talking about that. Why additional quoting for one of inner fields?.. |
It will be transparent in the future; it is currently stringified for the reasons above. |
Might be nice to update the docs to reflect this, at least. The weird serialization kind of hit me out of left field |
Seems to work not quite as expected, so this commit is for posterity and I may revert shortly after. For some reason, Sandbox wraps output in util.inspect(). See: <gf3/sandbox#16>
The resulting object is formed as:
Why? I suppose it breaks the semantic: why to add additional quoting for the result at that level of abstraction (the more - with util.inspect, which is usable for debugging purposes, not for serialization)?
The text was updated successfully, but these errors were encountered: