Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle flake8 git hook integration #30

Closed
wants to merge 2 commits into from
Closed

Handle flake8 git hook integration #30

wants to merge 2 commits into from

Conversation

gforcada
Copy link
Owner

See #28 for a detailed description.

sergio-alonso and others added 2 commits March 25, 2017 21:45
… hook.

Files with changes are moved to a temporal directory when flake8 git hook is used.

$ flake8 --install-hook git

flake8-isort should look for configuration files in the current directory while checking the files in the temporary directory.

Before fix, no configuration is found.

$ git commit -m "Commit message"
[DEBUG] full_path = /tmp/tmpl7f83uys/home/user/src/project/script.py
script.py:0:1: I002 no configuration found (.isort.cfg or [isort] on setup.cfg)

After fix, project configuration is found.

$ git commit -m "Commit message"
[DEBUG] full_path = /home/user/src/project/script.py
script.py:1:1: D200 One-line docstring should fit on one line with quotes
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 90.323% when pulling 04af82d on tmp-folder into 2eb59ac on master.

@gforcada
Copy link
Owner Author

Merged manually.

@gforcada gforcada closed this Mar 25, 2017
@gforcada gforcada deleted the tmp-folder branch March 25, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants