Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle flake8 git hook integration #30

Closed
wants to merge 2 commits into from
Closed

Handle flake8 git hook integration #30

wants to merge 2 commits into from

Commits on Mar 25, 2017

  1. I002 no configuration found when flake8-isort is used with flake8 git… 

    … hook.

Files with changes are moved to a temporal directory when flake8 git hook is used.

$ flake8 --install-hook git

flake8-isort should look for configuration files in the current directory while checking the files in the temporary directory.

Before fix, no configuration is found.

$ git commit -m "Commit message"
[DEBUG] full_path = /tmp/tmpl7f83uys/home/user/src/project/script.py
script.py:0:1: I002 no configuration found (.isort.cfg or [isort] on setup.cfg)

After fix, project configuration is found.

$ git commit -m "Commit message"
[DEBUG] full_path = /home/user/src/project/script.py
script.py:1:1: D200 One-line docstring should fit on one line with quotes
    @sergio-alonso @gforcada
    sergio-alonso authored and gforcada committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    dec0635 View commit details
    Browse the repository at this point in the history

  2. Extract code to make it reusable

    @gforcada
    gforcada committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    04af82d View commit details
    Browse the repository at this point in the history