Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make channel clonable as connection #69

Closed
gftea opened this issue Mar 9, 2023 · 0 comments · Fixed by #74
Closed

make channel clonable as connection #69

gftea opened this issue Mar 9, 2023 · 0 comments · Fixed by #74
Labels
enhancement New feature or request

Comments

@gftea
Copy link
Owner

gftea commented Mar 9, 2023

Current design disable clone of channel in order to protect them from interleaving the AMQP channel messages by using same channel in concurrent setup, but it decrease the flexibility of the library.
Instead, it would be better that user to just be aware of such limitation in AMQP protocol, but the library still allow for clone of channel.

Connection already support clone, and channel can follow the same design.
@gftea gftea added the enhancement New feature or request label Mar 9, 2023
gftea added a commit that referenced this issue Mar 24, 2023
@gftea
make channel clonable (#69)
8433685
gftea added a commit that referenced this issue Mar 24, 2023
@gftea
Merge pull request #74 from gftea/chan_dropguard
774470a 
make channel clonable (#69)
@gftea gftea mentioned this issue Mar 24, 2023
Merged
@gftea gftea closed this as completed Mar 24, 2023
@MrDarthShoe MrDarthShoe mentioned this issue Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make channel clonable (#69) gftea/amqprs
1 participant
@gftea