Setup TLS adaptor when parsing an amqprs uri

[tyilo]

No description provided.

[gftea]

@tyilo thanks for pr. Can you add a test for the case. And check ci error

[tyilo]

@gftea Everything should be working now, but the CI still fails. I can't reproduce it locally.

[gftea]

@tyilo it seems about feature flag , the test is expecting w/o tls, but still tls is used

api::connection::tests::test_amqps_scheme_without_tls stdout ----
thread 'api::connection::tests::test_amqps_scheme_without_tls' panicked at amqprs/src/api/connection.rs:1515:39:
called `Result::unwrap()` on an `Err` value: NetworkError("network io error: invalid peer certificate contents: invalid peer certificate: UnknownIssuer")
note: panic did not contain expected string
      panic message: `"called `Result::unwrap()` on an `Err` value: NetworkError(\"network io error: invalid peer certificate contents: invalid peer certificate: UnknownIssuer\")"`,
 expected substring: `"UriError"`

[tyilo]

@gftea I get the same error when running the tests on the main branch using cargo test --all-features --release, so again I don't that my changes causes it.

[gftea]

@tyilo I have rerun main branch, it works. see https://github.com/gftea/amqprs/actions
You can merge my latest ci update first to see if new run is ok.

Check your rustc version? Now latest stable is rustc 1.75.

Try do cargo clean and rerun on main, then if it works, try to run again on your own branch.

[tyilo]

@gftea Ah I understand now, I didn't have the RabbitMQ server running.

I see two possible solutions:

• Remove the test_amqps_scheme_without_tls test
• Keep the test_amqps_scheme_without_tls test, but change the signature of OpenConnectionArguments::tls_adaptor to take a Option<TlsAdaptor> instead of TlsAdaptor, so that the test can explicitly disable the default TLS adaptor.

What do you prefer?

[gftea]

@tyilo , the test is prevent user giving a amqps scheme (implies secure channel) but without tls adaptor enabled. it prevents the incorrect configuration from beginning

[tyilo]

@tyilo , the test is prevent user giving a amqps scheme (implies secure channel) but without tls adaptor enabled. it prevents the incorrect configuration from beginning

I understand what the test does. However, it is no longer possible to create a configuration from an amqps url without a TLS adaptor.

So do we want to:

1. remove the test, or
2. allow setting no TLS adaptor for an amqps URL

I don't really have a strong opinion about what to do. What do you prefer?

[so-schen]

I see, this PR implicitly setup an adaptor without client authentication if amqps scheme. HOW user can use amqps with its customized adapter?

[tyilo]

I see, this PR implicitly setup an adaptor without client authentication if amqps scheme. HOW user can use amqps with its customized adapter?

You then call tls_adaptor(...) as before to override the default adaptor.

The default should be without client authentication as this is the default for other AMQP libraries (and clients using TLS in general).

[gftea]

Ok, let’s remove this test case as you suggested. Please help add documentation about the default behavior and how to customize it

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07b5924) 85.49% compared to head (36cef87) 85.90%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   85.49%   85.90%   +0.40%     
==========================================
  Files          40       40              
  Lines        6206     6209       +3     
==========================================
+ Hits         5306     5334      +28     
+ Misses        900      875      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.