-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup TLS adaptor when parsing an amqprs uri #121
Conversation
@tyilo thanks for pr. Can you add a test for the case. And check ci error |
@gftea Everything should be working now, but the CI still fails. I can't reproduce it locally. |
@tyilo it seems about feature flag , the test is expecting w/o tls, but still tls is used
|
@gftea I get the same error when running the tests on the |
@tyilo I have rerun main branch, it works. see https://github.com/gftea/amqprs/actions Check your rustc version? Now latest stable is rustc 1.75. Try do cargo clean and rerun on |
@gftea Ah I understand now, I didn't have the RabbitMQ server running. I see two possible solutions:
What do you prefer? |
@tyilo , the test is prevent user giving a |
I understand what the test does. However, it is no longer possible to create a configuration from an So do we want to:
I don't really have a strong opinion about what to do. What do you prefer? |
I see, this PR implicitly setup an adaptor without client authentication if amqps scheme. HOW user can use amqps with its customized adapter? |
You then call The default should be without client authentication as this is the default for other AMQP libraries (and clients using TLS in general). |
Ok, let’s remove this test case as you suggested. Please help add documentation about the default behavior and how to customize it |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 85.49% 85.90% +0.40%
==========================================
Files 40 40
Lines 6206 6209 +3
==========================================
+ Hits 5306 5334 +28
+ Misses 900 875 -25 ☔ View full report in Codecov by Sentry. |
No description provided.