Skip to content

Commit

Permalink
Merge #2164 #2166
Browse files Browse the repository at this point in the history
2164: [mtl] Borrowed commands r=grovesNL a=kvark

PR checklist:
- [ ] `make` succeeds (on *nix)
- [x] `make reftests` succeeds
- [x] tested examples with the following backends:

r? @gfx-rs/metallists 

This PR attempts to have lightweight software commands that don't take any heap space or own ObjC objects. In most cases, where a command list is live-recorded and executed once, this should reduce the amount of work we do per command, which is especially important if those commands are thrown away (e.g. because we are not inside a render pass).

My expectation would be to see an improvement in #2161 due to us doing less work. The actual results are somewhat shocking: with v-sync enabled I'm getting the same 59-60 fps as usual. With v-sync OFF, I'm getting between 25 and 50 fps now (which is lower than the previous 50-70). Not sure what's going on, the instrumental profile doesn't give a clue. Please check out the code.

2166: Update example instructions in README.md r=kvark a=king6cong



Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: king6cong <king6cong@gmail.com>
  • Loading branch information
3 people committed Jun 22, 2018
3 parents 0e1c915 + 90fd193 + 4c7a4ac commit 6eada8f
Show file tree
Hide file tree
Showing 6 changed files with 1,313 additions and 843 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,12 @@ To run an example, simply use `cargo run` and specify the backend with `--featur

```bash
git clone https://github.com/gfx-rs/gfx
cd gfx/examples/hal
cd gfx/examples
# macOS
cargo run --bin quad --features metal
# vulkan
cargo run --bin quad --features vulkan
# Windows
cargo run --bin compute --features dx12 1 2 3 4
```

Expand Down
Loading

0 comments on commit 6eada8f

Please sign in to comment.