Update example instructions in README.md #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timed out |
|
bors retry |
Timed out |
|
bors retry |
1 similar comment
|
bors retry |
|
bors r+ |
|
Not awaiting review |
1 similar comment
|
Not awaiting review |
Build failed |
|
bors retry |
|
I don't think retry works as expected... |
|
Not awaiting review |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2018
2071: Remaping descriptor sets in the gl backend r=kvark a=ZeGentzy I'll rebase off master when I'm done. Uniforms in gl only have a bindings field, not a set one. This means that for shaders that use multiple sets to work, we must change where we are binding them. See page 14 for what I mean: https://www.khronos.org/assets/uploads/developers/library/2016-vulkan-devday-uk/4-Using-spir-v-with-spirv-cross.pdf PR checklist: - [ ] `make` succeeds (on *nix) - [ ] `make reftests` succeeds - [ ] tested examples with the following backends: 2164: [mtl] Borrowed commands r=grovesNL a=kvark PR checklist: - [ ] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: r? @gfx-rs/metallists This PR attempts to have lightweight software commands that don't take any heap space or own ObjC objects. In most cases, where a command list is live-recorded and executed once, this should reduce the amount of work we do per command, which is especially important if those commands are thrown away (e.g. because we are not inside a render pass). My expectation would be to see an improvement in #2161 due to us doing less work. The actual results are somewhat shocking: with v-sync enabled I'm getting the same 59-60 fps as usual. With v-sync OFF, I'm getting between 25 and 50 fps now (which is lower than the previous 50-70). Not sure what's going on, the instrumental profile doesn't give a clue. Please check out the code. 2166: Update example instructions in README.md r=kvark a=king6cong Co-authored-by: Hal Gentz <zegentzy@protonmail.com> Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com> Co-authored-by: king6cong <king6cong@gmail.com>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Jun 22, 2018
2164: [mtl] Borrowed commands r=grovesNL a=kvark PR checklist: - [ ] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: r? @gfx-rs/metallists This PR attempts to have lightweight software commands that don't take any heap space or own ObjC objects. In most cases, where a command list is live-recorded and executed once, this should reduce the amount of work we do per command, which is especially important if those commands are thrown away (e.g. because we are not inside a render pass). My expectation would be to see an improvement in #2161 due to us doing less work. The actual results are somewhat shocking: with v-sync enabled I'm getting the same 59-60 fps as usual. With v-sync OFF, I'm getting between 25 and 50 fps now (which is lower than the previous 50-70). Not sure what's going on, the instrumental profile doesn't give a clue. Please check out the code. 2166: Update example instructions in README.md r=kvark a=king6cong Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com> Co-authored-by: king6cong <king6cong@gmail.com>
Build failed (retrying...) |
Build failed |
|
Bors retry
… On Jun 22, 2018, at 15:28, bors[bot] ***@***.***> wrote:
Build failed
continuous-integration/travis-ci/push
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
bors r+ |
|
Not awaiting review |
Timed out |
|
Bors retry
… On Jun 23, 2018, at 04:46, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
bors r+ |
|
Not awaiting review |
Timed out |
|
Bors retry
… On Jun 23, 2018, at 14:50, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@kvark looks like we need to retry this again |
|
It didn't seem to do anything |
|
Bors r+
… On Jul 10, 2018, at 20:32, Josh Groves ***@***.***> wrote:
It didn't seem to do anything
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Timed out |
|
Bors retry
… On Jul 11, 2018, at 02:23, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Timed out |
|
Bors r+
… On Jul 11, 2018, at 12:52, bors[bot] ***@***.***> wrote:
Timed out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Can't believe this happened :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.