Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-threaded compile-time configuration #721

Closed
kvark opened this issue May 9, 2015 · 2 comments
Closed

Single-threaded compile-time configuration #721

kvark opened this issue May 9, 2015 · 2 comments
Labels
difficulty: average status: ready for work type: feature value: medium

Comments

@kvark
Copy link
Member

kvark commented May 9, 2015

We could have a cfg(single) switch, effectively working around #636. For single-threaded, we'd use regular Rc instead of custom Arc.

cc @csherratt @cmr
@ghost
Copy link

ghost commented May 9, 2015

Rc is_unique is still not stable.. So, we are blocked on that unless we want to make cfg(single) change the internal Arc.

@kvark
Copy link
Member Author

kvark commented Feb 12, 2019

Not happened in pre-ll

@kvark kvark closed this as completed Feb 12, 2019
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @cwfitzgerald
Merge gfx-rs#1128
9dce0af 
1128: Add pipeline statistics and timeline queries r=kvark a=cwfitzgerald

**Connections**

Closes gfx-rs#721 

**Description**

This adds Pipeline Statistics queries and Timeline queries. Shoutout to @z2oh for doing a good chunk of the work to enable this feature.

Currently blocked on both gfx-rs#3563 and rollup of gfx-hal mutability changes, but is ready to review.

**Testing**

Tested in various ways on the hello-compute and hello-triangle example, tested validation extensively. Queries will be permanently added to the mipmap example once the wgpu-rs PR is finished.

Co-authored-by: Connor Fitzgerald <connorwadefitzgerald@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: average status: ready for work type: feature value: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kvark