Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract away reference counting #636

Closed
kvark opened this issue Mar 8, 2015 · 3 comments
Closed

Abstract away reference counting #636

kvark opened this issue Mar 8, 2015 · 3 comments
Labels
difficulty: average status: blocked type: feature value: medium

Comments

@kvark
Copy link
Member

kvark commented Mar 8, 2015

The current implementation (#633) uses Arc. The plan (outlined in #288) is to support Rc for single-threaded and Arc for multi-threaded. We could use a common trait similar to this
@kvark kvark mentioned this issue Mar 8, 2015
Closed
7 tasks
@kvark
Copy link
Member Author

kvark commented Mar 10, 2015

I did a quick run at it and found that HKT are required. Leaving the status as blocked.

@bvssvni
Copy link
Contributor

bvssvni commented Mar 10, 2015

I don't think Rc is important now, and would like to test the new architecture before adding more abstractions.

@kvark kvark mentioned this issue Mar 30, 2015
Merged
@kvark kvark mentioned this issue May 9, 2015
Closed
@kvark
Copy link
Member Author

kvark commented Feb 12, 2019

Not happened in pre-ll

@kvark kvark closed this as completed Feb 12, 2019
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#636
1e43daf 
636: Properly destroy swap chains r=kvark a=kvark

This is the last piece of the cleanup puzzle, I think, as closing an example becomes fully validation-free 🎉 

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#637
644949d 
637: Wait for idle before destroying swapchains r=kvark a=kvark

Follow up to gfx-rs#636 
I was trying to address the D3D12 error in gfx-rs#3242
The debug messages complain about a resource being used by the queue while it's being destroyed. I thought forcing a wait there would help, but it does not. I think it's still a good change to land though.

In the meantime, I wonder if it considers the swapchain to be used because it's currently presented. Could be something else I'm missing here.

Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: average status: blocked type: feature value: medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kvark @bvssvni