The new shader parameter system #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type, switched ShaderParam to use generics where needed.
|
This is awesome. |
| @@ -1,17 +1,24 @@ | |||
| #![feature(phase)] | |||
| #![crate_name = "triangle"] | |||
|
|
|||
| #[phase(link, plugin)] | |||
| #[phase(plugin)] | |||
| extern crate macro; | |||
There was a problem hiding this comment.
Seeing this example, it could be named gfx_macros or similar, to avoid confusion...
|
r+ |
Closed
| impl<'a> MetaSink<'a> { | ||
| /// Creates a new wrapper | ||
| pub fn new(meta: &'a dev::ProgramMeta) -> MetaSink<'a> { | ||
| assert_eq!(0, meta.uniforms.len()>>(8*size_of::<MaskUniform>())); |
There was a problem hiding this comment.
Could these be debug_assert!(0 == ...)?
There was a problem hiding this comment.
I thought about it, but then figured - it's not really a big cost for the run-time, since it's only done during initialization.
There was a problem hiding this comment.
Even so it can prevent inlining due to generating a lot of code (it turns into a conditional with a fail!() and some complex formatting).
emberian
added a commit
that referenced
this pull request
Jul 23, 2014
The new shader parameter system
adamnemecek
pushed a commit
to adamnemecek/gfx
that referenced
this pull request
Apr 1, 2021
116: Validation bits from 0.2 r=kvark a=kvark Sibling of gfx-rs#114 Co-authored-by: Dzmitry Malyshau <dmalyshau@mozilla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19